1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
|
// Copyright 2021 The libgav1 Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
#include "src/threading_strategy.h"
#include <memory>
#include <utility>
#include <vector>
#include "absl/strings/str_cat.h"
#include "gtest/gtest.h"
#include "src/frame_scratch_buffer.h"
#include "src/obu_parser.h"
#include "src/utils/constants.h"
#include "src/utils/threadpool.h"
#include "src/utils/types.h"
namespace libgav1 {
namespace {
class ThreadingStrategyTest : public testing::Test {
protected:
ThreadingStrategy strategy_;
ObuFrameHeader frame_header_ = {};
};
TEST_F(ThreadingStrategyTest, MaxThreadEnforced) {
frame_header_.tile_info.tile_count = 32;
ASSERT_TRUE(strategy_.Reset(frame_header_, 32));
EXPECT_NE(strategy_.tile_thread_pool(), nullptr);
for (int i = 0; i < 32; ++i) {
EXPECT_EQ(strategy_.row_thread_pool(i), nullptr);
}
EXPECT_NE(strategy_.post_filter_thread_pool(), nullptr);
}
TEST_F(ThreadingStrategyTest, UseAllThreadsForTiles) {
frame_header_.tile_info.tile_count = 8;
ASSERT_TRUE(strategy_.Reset(frame_header_, 8));
EXPECT_NE(strategy_.tile_thread_pool(), nullptr);
for (int i = 0; i < 8; ++i) {
EXPECT_EQ(strategy_.row_thread_pool(i), nullptr);
}
EXPECT_NE(strategy_.post_filter_thread_pool(), nullptr);
}
TEST_F(ThreadingStrategyTest, RowThreads) {
frame_header_.tile_info.tile_count = 2;
ASSERT_TRUE(strategy_.Reset(frame_header_, 8));
EXPECT_NE(strategy_.tile_thread_pool(), nullptr);
// Each tile should get 3 threads each.
for (int i = 0; i < 2; ++i) {
EXPECT_NE(strategy_.row_thread_pool(i), nullptr);
}
EXPECT_NE(strategy_.post_filter_thread_pool(), nullptr);
}
TEST_F(ThreadingStrategyTest, RowThreadsUnequal) {
frame_header_.tile_info.tile_count = 2;
ASSERT_TRUE(strategy_.Reset(frame_header_, 9));
EXPECT_NE(strategy_.tile_thread_pool(), nullptr);
EXPECT_NE(strategy_.row_thread_pool(0), nullptr);
EXPECT_NE(strategy_.row_thread_pool(1), nullptr);
EXPECT_NE(strategy_.post_filter_thread_pool(), nullptr);
}
// Test a random combination of tile_count and thread_count.
TEST_F(ThreadingStrategyTest, MultipleCalls) {
frame_header_.tile_info.tile_count = 2;
ASSERT_TRUE(strategy_.Reset(frame_header_, 8));
EXPECT_NE(strategy_.tile_thread_pool(), nullptr);
for (int i = 0; i < 2; ++i) {
EXPECT_NE(strategy_.row_thread_pool(i), nullptr);
}
EXPECT_NE(strategy_.post_filter_thread_pool(), nullptr);
frame_header_.tile_info.tile_count = 8;
ASSERT_TRUE(strategy_.Reset(frame_header_, 8));
EXPECT_NE(strategy_.tile_thread_pool(), nullptr);
// Row threads must have been reset.
for (int i = 0; i < 8; ++i) {
EXPECT_EQ(strategy_.row_thread_pool(i), nullptr);
}
EXPECT_NE(strategy_.post_filter_thread_pool(), nullptr);
frame_header_.tile_info.tile_count = 8;
ASSERT_TRUE(strategy_.Reset(frame_header_, 16));
EXPECT_NE(strategy_.tile_thread_pool(), nullptr);
for (int i = 0; i < 8; ++i) {
EXPECT_NE(strategy_.row_thread_pool(i), nullptr);
}
EXPECT_NE(strategy_.post_filter_thread_pool(), nullptr);
frame_header_.tile_info.tile_count = 4;
ASSERT_TRUE(strategy_.Reset(frame_header_, 16));
EXPECT_NE(strategy_.tile_thread_pool(), nullptr);
for (int i = 0; i < 4; ++i) {
EXPECT_NE(strategy_.row_thread_pool(i), nullptr);
}
// All the other row threads must be reset.
for (int i = 4; i < 8; ++i) {
EXPECT_EQ(strategy_.row_thread_pool(i), nullptr);
}
EXPECT_NE(strategy_.post_filter_thread_pool(), nullptr);
frame_header_.tile_info.tile_count = 4;
ASSERT_TRUE(strategy_.Reset(frame_header_, 6));
EXPECT_NE(strategy_.tile_thread_pool(), nullptr);
// First two tiles will get 1 thread each.
for (int i = 0; i < 2; ++i) {
EXPECT_NE(strategy_.row_thread_pool(i), nullptr);
}
// All the other row threads must be reset.
for (int i = 2; i < 8; ++i) {
EXPECT_EQ(strategy_.row_thread_pool(i), nullptr);
}
EXPECT_NE(strategy_.post_filter_thread_pool(), nullptr);
ASSERT_TRUE(strategy_.Reset(frame_header_, 1));
EXPECT_EQ(strategy_.tile_thread_pool(), nullptr);
for (int i = 0; i < 8; ++i) {
EXPECT_EQ(strategy_.row_thread_pool(i), nullptr);
}
EXPECT_EQ(strategy_.post_filter_thread_pool(), nullptr);
}
// Tests the following order of calls (with thread count fixed at 4):
// * 1 Tile - 2 Tiles - 1 Tile.
TEST_F(ThreadingStrategyTest, MultipleCalls2) {
frame_header_.tile_info.tile_count = 1;
ASSERT_TRUE(strategy_.Reset(frame_header_, 4));
// When there is only one tile, tile thread pool must be nullptr.
EXPECT_EQ(strategy_.tile_thread_pool(), nullptr);
EXPECT_NE(strategy_.row_thread_pool(0), nullptr);
for (int i = 1; i < 8; ++i) {
EXPECT_EQ(strategy_.row_thread_pool(i), nullptr);
}
EXPECT_NE(strategy_.post_filter_thread_pool(), nullptr);
frame_header_.tile_info.tile_count = 2;
ASSERT_TRUE(strategy_.Reset(frame_header_, 4));
EXPECT_NE(strategy_.tile_thread_pool(), nullptr);
for (int i = 0; i < 2; ++i) {
EXPECT_NE(strategy_.row_thread_pool(i), nullptr);
}
for (int i = 2; i < 8; ++i) {
EXPECT_EQ(strategy_.row_thread_pool(i), nullptr);
}
EXPECT_NE(strategy_.post_filter_thread_pool(), nullptr);
frame_header_.tile_info.tile_count = 1;
ASSERT_TRUE(strategy_.Reset(frame_header_, 4));
EXPECT_EQ(strategy_.tile_thread_pool(), nullptr);
EXPECT_NE(strategy_.row_thread_pool(0), nullptr);
for (int i = 1; i < 8; ++i) {
EXPECT_EQ(strategy_.row_thread_pool(i), nullptr);
}
EXPECT_NE(strategy_.post_filter_thread_pool(), nullptr);
}
void VerifyFrameParallel(int thread_count, int tile_count, int tile_columns,
int expected_frame_threads,
const std::vector<int>& expected_tile_threads) {
ASSERT_EQ(expected_frame_threads, expected_tile_threads.size());
ASSERT_GT(thread_count, 1);
std::unique_ptr<ThreadPool> frame_thread_pool;
FrameScratchBufferPool frame_scratch_buffer_pool;
ASSERT_TRUE(InitializeThreadPoolsForFrameParallel(
thread_count, tile_count, tile_columns, &frame_thread_pool,
&frame_scratch_buffer_pool));
if (expected_frame_threads == 0) {
EXPECT_EQ(frame_thread_pool, nullptr);
return;
}
EXPECT_NE(frame_thread_pool.get(), nullptr);
EXPECT_EQ(frame_thread_pool->num_threads(), expected_frame_threads);
std::vector<std::unique_ptr<FrameScratchBuffer>> frame_scratch_buffers;
int actual_thread_count = frame_thread_pool->num_threads();
for (int i = 0; i < expected_frame_threads; ++i) {
SCOPED_TRACE(absl::StrCat("i: ", i));
frame_scratch_buffers.push_back(frame_scratch_buffer_pool.Get());
ThreadPool* const thread_pool =
frame_scratch_buffers.back()->threading_strategy.thread_pool();
if (expected_tile_threads[i] > 0) {
EXPECT_NE(thread_pool, nullptr);
EXPECT_EQ(thread_pool->num_threads(), expected_tile_threads[i]);
actual_thread_count += thread_pool->num_threads();
} else {
EXPECT_EQ(thread_pool, nullptr);
}
}
EXPECT_EQ(thread_count, actual_thread_count);
for (auto& frame_scratch_buffer : frame_scratch_buffers) {
frame_scratch_buffer_pool.Release(std::move(frame_scratch_buffer));
}
}
TEST(FrameParallelStrategyTest, FrameParallel) {
// This loop has thread_count <= 3 * tile count. So there should be no frame
// threads irrespective of the number of tile columns.
for (int thread_count = 2; thread_count <= 6; ++thread_count) {
VerifyFrameParallel(thread_count, /*tile_count=*/2, /*tile_columns=*/1,
/*expected_frame_threads=*/0,
/*expected_tile_threads=*/{});
VerifyFrameParallel(thread_count, /*tile_count=*/2, /*tile_columns=*/2,
/*expected_frame_threads=*/0,
/*expected_tile_threads=*/{});
}
// Equal number of tile threads for each frame thread.
VerifyFrameParallel(
/*thread_count=*/8, /*tile_count=*/1, /*tile_columns=*/1,
/*expected_frame_threads=*/4, /*expected_tile_threads=*/{1, 1, 1, 1});
VerifyFrameParallel(
/*thread_count=*/12, /*tile_count=*/2, /*tile_columns=*/2,
/*expected_frame_threads=*/4, /*expected_tile_threads=*/{2, 2, 2, 2});
VerifyFrameParallel(
/*thread_count=*/18, /*tile_count=*/2, /*tile_columns=*/2,
/*expected_frame_threads=*/6,
/*expected_tile_threads=*/{2, 2, 2, 2, 2, 2});
VerifyFrameParallel(
/*thread_count=*/16, /*tile_count=*/3, /*tile_columns=*/3,
/*expected_frame_threads=*/4, /*expected_tile_threads=*/{3, 3, 3, 3});
// Unequal number of tile threads for each frame thread.
VerifyFrameParallel(
/*thread_count=*/7, /*tile_count=*/1, /*tile_columns=*/1,
/*expected_frame_threads=*/3, /*expected_tile_threads=*/{2, 1, 1});
VerifyFrameParallel(
/*thread_count=*/14, /*tile_count=*/2, /*tile_columns=*/2,
/*expected_frame_threads=*/4, /*expected_tile_threads=*/{3, 3, 2, 2});
VerifyFrameParallel(
/*thread_count=*/20, /*tile_count=*/2, /*tile_columns=*/2,
/*expected_frame_threads=*/6,
/*expected_tile_threads=*/{3, 3, 2, 2, 2, 2});
VerifyFrameParallel(
/*thread_count=*/17, /*tile_count=*/3, /*tile_columns=*/3,
/*expected_frame_threads=*/4, /*expected_tile_threads=*/{4, 3, 3, 3});
}
TEST(FrameParallelStrategyTest, ThreadCountDoesNotExceedkMaxThreads) {
std::unique_ptr<ThreadPool> frame_thread_pool;
FrameScratchBufferPool frame_scratch_buffer_pool;
ASSERT_TRUE(InitializeThreadPoolsForFrameParallel(
/*thread_count=*/kMaxThreads + 10, /*tile_count=*/2, /*tile_columns=*/2,
&frame_thread_pool, &frame_scratch_buffer_pool));
EXPECT_NE(frame_thread_pool.get(), nullptr);
std::vector<std::unique_ptr<FrameScratchBuffer>> frame_scratch_buffers;
int actual_thread_count = frame_thread_pool->num_threads();
for (int i = 0; i < frame_thread_pool->num_threads(); ++i) {
SCOPED_TRACE(absl::StrCat("i: ", i));
frame_scratch_buffers.push_back(frame_scratch_buffer_pool.Get());
ThreadPool* const thread_pool =
frame_scratch_buffers.back()->threading_strategy.thread_pool();
if (thread_pool != nullptr) {
actual_thread_count += thread_pool->num_threads();
}
}
// In this case, the exact number of frame threads and tile threads depend on
// the value of kMaxThreads. So simply ensure that the total number of threads
// does not exceed kMaxThreads.
EXPECT_LE(actual_thread_count, kMaxThreads);
for (auto& frame_scratch_buffer : frame_scratch_buffers) {
frame_scratch_buffer_pool.Release(std::move(frame_scratch_buffer));
}
}
} // namespace
} // namespace libgav1
|
