| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
inlined port rights.
For i686, we just change the code to use mach_port_name_inlined_t when
defining the types. This is a no-op.
For x86_64, there's a few things that are different:
- In the server code, the server handler can get inlined ports and the
array will be resized and cast as an array of mach_port_name_t. Output
parameters have a similar treatment where the inlined array in the
output is used as an array of mach_port_name_t but resized to look like
a mach_port_name_inlined_t.
- In the user side, we follow the same approach. Input ports as arrays
of mach_port_name_t are expanded into an array of mach_port_name_inlined_t.
Output ports are then converted back into an array of
mach_port_name_inlined_t so that they fit into the expected message
format.
Essentially, regardless of whether port rights are inline or out of
line, user interfaces and server stubs always receive an array of port
rights, not mach_port_name_inlined_t. However, inlined port rights will
be exchanged using mach_port_name_inlined_t.
|
| |
|
|
|
|
| |
for inlined port rights."
This reverts commit c40604042bd6e9f80e4f5fe6bc9deefb29c4b94a.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
inlined port rights.
For i686, we just change the code to use mach_port_name_inlined_t when
defining the types. This is a no-op.
For x86_64, there's a few things that are different:
- In the server code, the server handler can get inlined ports and the
array will be resized and cast as an array of mach_port_name_t. Output
parameters have a similar treatment where the inlined array in the
output is used as an array of mach_port_name_t but resized to look like
a mach_port_name_inlined_t.
- In the user side, we follow the same approach. Input ports as arrays
of mach_port_name_t are expanded into an array of mach_port_name_inlined_t.
Output ports are then converted back into an array of
mach_port_name_inlined_t so that they fit into the expected message
format.
Essentially, regardless of whether port rights are inline or out of
line, user interfaces and server stubs always receive an array of port
rights, not mach_port_name_inlined_t. However, inlined port rights will
be exchanged using mach_port_name_inlined_t.
Message-ID: <20231124213041.952886-4-flaviocruz@gmail.com>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
By using uintptr_t, we ensure that all 64 bit stubs are free of
undefined behavior since we support up to 8-byte alignment. This works
fine given that Mig will type check types that have higher alignment
requirements through the use of _Static_assert.
This even works for a 64 bit kernel / 32 bit user land since we can use
mig64 to build stubs for the 8-byte aligned kernel stubs and existing 32
bit mig to build the old user side stubs. Pragma is no longer required as we take
advantage of the compiler to drive the alignment and avoid undefined
behavior.
Message-Id: <Y/KsiXZKkq1q/D+3@jupiter.tail36e24.ts.net>
|
| |
|
|
|
|
|
| |
Remove the concept of word_size since it is meaningless in some
architectures. This is also done in preparation to possibly introduce
8-byte aligned messages.
Message-Id: <Y+lkv0uMo/3+hbCb@jupiter.tail36e24.ts.net>
|
| |
|
|
| |
Message-Id: <Y6CAwaY0IRqihOjU@mars>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* cpu.sym: retrieve size of vm_offset_t and mach_port_name_t from
gnumach headers at compile type.
* global.{c,h}: add port size as a variable and initialize it to the
port name size.
* lexxer.l: apply port or port name size to the corresponding types,
instead of using the word size.
* parser.y: update port size if we're generating for kernel-space
(server or client). Also re-initialize default port types to account
for this change.
* type.c: use port size instead of word size in default port types and
runtime checks.
There are many assumptions about mach_port_t:
- on kernel side, its size is the same as a pointer. This allows to
replace the port name with the address of the corresponding data
structure during copyin in mach_msg()
- in mig, this is also the "word size", which is derived from gnumach
headers as the size of integer_t
- its size is also the same as natural_t, so it's possible to model
structures like mach_port_status_t as an array of integer_t in
mig. This is convenient since arrays and structures can't have
mixed types.
- its size is always the same as the port name size
This patch does not change the current behaviour on 32-bit kernels,
but allows for some of these assumptions to be broken on 64-bit
kernels. This is needed to have 32-bit port names on 64-bit kernels
and be able to support a 32-bit userspace. It still leaves the choice
for a 64-bit userspace, if all integer_t and natural_t are to be
extended to 64 bit.
However keeping 32-bit port names seems to be the right thing, based on
previous discussions [1], even for a 64-bit kernel.
The only assumption kept is that in kernel-space ports are always the
size of a pointer, as they refer to a data structure and not to a
specific port name. To ensure this is true for various user/kernel
combinations, we dynamically change the port size if we're generating
code for kernel-space server or clients, and keep the size of a port the
same of a port name for user-space servers and clients.
[1] https://lists.gnu.org/archive/html/bug-hurd/2012-04/msg00000.html
Signed-off-by: Luca Dariz <luca@orpolo.org>
Message-Id: <20220403150020.120799-2-luca@orpolo.org>
|
| |
|
|
| |
* cpu.sym: Add sizeof_long, sizeof_float, sizeof_double.
|
| |
|
|
|
|
|
|
|
|
| |
This replaces the implementation from the University of Utah, covered by the
advertising clause, with the implementation from CMU, picked up from the GNU
Mach source, which is free from the advertising clause.
This includes the addition of the sizeof as seen used by mig with
git grep word_size
git grep sizeof_
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also removed itMakeIntType which was not used anymore.
Users can use char, int, and short types without having to define them.
These types are defined using the builtin MACH_MSG_TYPE_* types and are
architecture independent since they have the same size as the C char,
short and int.
If these basic types are redefined, MIG will still produce stub code but
will produce a warning.
* cpu.sym: Define sizeof_int, char, short.
* tests/base_types.defs: Remove int.
* tests/good/complex-types.defs: Use byte instead of char.
* tests/good/directions: Remove char and int.
* tests/good/types.defs: Remove char and also use short as a parameter
in 'alltypes'.
* type.c: Define itCIntTypeDecl. Remove itMakeIntType. Call itInsert for
char, short and int.
Message-Id: <20160419070513.GA12642@debian>
|
| |
|
