aboutsummaryrefslogtreecommitdiff
path: root/utils.c
Commit message (Collapse)AuthorAgeFilesLines
* Use char* for inlined arrays of char in user headersFlavio Cruz2023-12-291-6/+24
| | | | | | | | | | | | | This changes how we declare RPC user prototypes for device_read_inband to use "char *data" rather than "io_buf_ptr_inband_t data". It is more standard to pass a pointer to represent arrays compared to "char [128]". This fixes a warning in console-client since GCC won't complain we are not passing an exact char [128]. Also updated code to use const_io_buf_ptr_inband_t for device_write_inband. This is a pointer to const data rather than a const pointer. Message-ID: <ZY7u7noOnHlyJi24@jupiter.tail36e24.ts.net>
* x86_64: adapt MiG generated stubs to use mach_port_name_inlined_t for ↵Flavio Cruz2023-12-171-6/+22
| | | | | | | | | | | | | | | | | | | | | | | | inlined port rights. For i686, we just change the code to use mach_port_name_inlined_t when defining the types. This is a no-op. For x86_64, there's a few things that are different: - In the server code, the server handler can get inlined ports and the array will be resized and cast as an array of mach_port_name_t. Output parameters have a similar treatment where the inlined array in the output is used as an array of mach_port_name_t but resized to look like a mach_port_name_inlined_t. - In the user side, we follow the same approach. Input ports as arrays of mach_port_name_t are expanded into an array of mach_port_name_inlined_t. Output ports are then converted back into an array of mach_port_name_inlined_t so that they fit into the expected message format. Essentially, regardless of whether port rights are inline or out of line, user interfaces and server stubs always receive an array of port rights, not mach_port_name_inlined_t. However, inlined port rights will be exchanged using mach_port_name_inlined_t.
* Revert "x86_64: adapt MiG generated stubs to use mach_port_name_inlined_t ↵Samuel Thibault2023-12-031-22/+6
| | | | | | for inlined port rights." This reverts commit c40604042bd6e9f80e4f5fe6bc9deefb29c4b94a.
* x86_64: adapt MiG generated stubs to use mach_port_name_inlined_t for ↵Flavio Cruz2023-12-031-6/+22
| | | | | | | | | | | | | | | | | | | | | | | | | inlined port rights. For i686, we just change the code to use mach_port_name_inlined_t when defining the types. This is a no-op. For x86_64, there's a few things that are different: - In the server code, the server handler can get inlined ports and the array will be resized and cast as an array of mach_port_name_t. Output parameters have a similar treatment where the inlined array in the output is used as an array of mach_port_name_t but resized to look like a mach_port_name_inlined_t. - In the user side, we follow the same approach. Input ports as arrays of mach_port_name_t are expanded into an array of mach_port_name_inlined_t. Output ports are then converted back into an array of mach_port_name_inlined_t so that they fit into the expected message format. Essentially, regardless of whether port rights are inline or out of line, user interfaces and server stubs always receive an array of port rights, not mach_port_name_inlined_t. However, inlined port rights will be exchanged using mach_port_name_inlined_t. Message-ID: <20231124213041.952886-4-flaviocruz@gmail.com>
* Update code generation to handle the new 64 bit ABIFlavio Cruz2023-09-241-8/+19
| | | | | | | | | | Mostly, we don't set the fields that do not exist and avoid type mismatching (like casting unsigned short to unsigned char for msgt_name). We also revamp type checking to compare mach_msg_type_t to uint64_t instead of just uint32_t as we now use the whole structure. Message-Id: <ZGREMgn19Zptc/Pf@jupiter.tail36e24.ts.net>
* Fix printing size_tSamuel Thibault2023-05-201-2/+2
|
* Use designated initializers for mach_msg_type_t and mach_msg_type_long_t.Flavio Cruz2023-03-081-26/+26
| | | | Message-Id: <ZAbgdBuKlIIiF6zA@jupiter.tail36e24.ts.net>
* Change complex_align_of to be sizeof(uintptr_t)Flavio Cruz2023-02-271-2/+0
| | | | | | | | | | | | | | By using uintptr_t, we ensure that all 64 bit stubs are free of undefined behavior since we support up to 8-byte alignment. This works fine given that Mig will type check types that have higher alignment requirements through the use of _Static_assert. This even works for a 64 bit kernel / 32 bit user land since we can use mig64 to build stubs for the 8-byte aligned kernel stubs and existing 32 bit mig to build the old user side stubs. Pragma is no longer required as we take advantage of the compiler to drive the alignment and avoid undefined behavior. Message-Id: <Y/KsiXZKkq1q/D+3@jupiter.tail36e24.ts.net>
* Also align mach_msg_type_long_t to complex_alignofFlavio Cruz2023-02-271-3/+8
| | | | | | This was a miss in the previous patch given that mach_msg_type_long_t is 12 bytes long so won't neatly align to 8 bytes. Message-Id: <Y+8VyADQ8+bRRUcp@jupiter.tail36e24.ts.net>
* Introduce complex_alignof to replace word_sizeFlavio Cruz2023-02-131-1/+5
| | | | | | | Remove the concept of word_size since it is meaningless in some architectures. This is also done in preparation to possibly introduce 8-byte aligned messages. Message-Id: <Y+lkv0uMo/3+hbCb@jupiter.tail36e24.ts.net>
* mig: replace boolean.h with stdbool.hFlavio Cruz2022-11-251-16/+16
| | | | Message-Id: <Y3/Z1CGL8D4OwT66@viriathus>
* fix message fields alignment for 64 bitLuca Dariz2022-08-271-0/+2
| | | | | | | | | | | | | | | On x86_64 alignment of structures is different, as the pointer size is different. For simplicity we keep the same 4-byte alignment as used on 32-bit. This simplifies the support for 32-bit rpc on 64-bit kernels, and also it seems not worth as an optimization, as we would need to add more code in the ipc_kmsg* routines. * routine.c: align both short and long descriptors * utils.c: use a fixed alignment for data fields in structures representing messages. Signed-off-by: Luca Dariz <luca@orpolo.org> Message-Id: <20220628094927.442907-2-luca@orpolo.org>
* Add _Static_assert when compiling server and user stubs.Flavio Cruz2022-01-211-7/+32
| | | | | | | | | This is only done when data is inlined with a concrete size. It ensures the C and Mig types have the same size in the target arch. Tested by building the hurd package. No assertions were triggered. Message-Id: <YekIQaxvs+4FrHyw@viriathus>
* Also add const qualifiers on server sideSamuel Thibault2022-01-161-2/+31
| | | | | Although in practice the buffers can be modified since they are from the message, it leads to missing const where it would otherwise make sense.
* Make dev_name_t also use const_dev_name_tSamuel Thibault2022-01-161-0/+2
| | | | to avoid forcing the caller to respect the definite string size.
* Make string_t always use const_string_tSamuel Thibault2020-11-301-3/+7
| | | | | | | | | | This will allow to relieve constraints in callers, e.g. dir_lookup("") would otherwise produce a warning with gcc-11 since char[1024] would mean that dir_lookup would read all 1024 characters while it is not. * utils.c (UserVarQualifier): Also use const_ qualifier when type is string_t. * tests/includes/types.h (const_string_t): New type.
* Fix RPC build warningsSamuel Thibault2018-01-281-2/+28
| | | | | | | | | | Users of RPCs want to be able to pass pointers to const data, so add const qualifiers to RPCs as appropriate. * utils.c (UserVarConst, UserVarQualifier): New functions. (WriteUserVarDecl): Use UserVarQualifier to qualify function parameter. (WriteFieldDeclPrim): Use UserVarConst to qualify pointer to user variable.
* Fix compilation warningsSamuel Thibault2018-01-281-4/+3
| | | | | | | | | Nowadays' compilers are able to recognize memcpy and replace it appropriately without having to tell them so through a structure assignment. That also avoids warnings about type puning. * utils.c (WriteCopyType): Emit memcpy call instead of type-puned assignement.
* Fix spurious warning on MACH_MSG_TYPE_POLYMORPHIC valueSamuel Thibault2017-01-021-1/+1
| | | | | * utils.c (WriteStaticLongDecl): Explicitly cast name to unsigned short to ignore truncation of MACH_MSG_TYPE_POLYMORPHIC i.e. -1.
* Fix spurious warning on MACH_MSG_TYPE_POLYMORPHIC valueSamuel Thibault2016-10-101-2/+2
| | | | | * utils.c (WriteCheckDecl, WriteStaticShortDecl): Explicitly cast name to unsigned char to ignore truncation of MACH_MSG_TYPE_POLYMORPHIC i.e. -1.
* Use uint32_t instead of unsigned32_t.Flavio Cruz2016-04-041-1/+1
| | | | * utils.c: Generate code using uint32_t.
* Do not generate code dereferencing type-punned pointersJustus Winter2015-02-151-1/+7
| | | | | | | | | | | | | | | | | | | | | | For variable-length arrays, up to 2048 bytes are transmitted inline. If the array is larger, the data is transmitted out-of-line, and a pointer to a vm_allocated region is stored at the beginning of the array. Previously, the generated code casted the field. Use a union instead. This fixes the gcc warning `dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]'. * global.c (OOLPostfix): New variable. * global.h (OOLPostfix): New declaration. * server.c (WriteServerCallArg): Avoid cast. (WriteDestroyArg): Likewise. (WritePackArgValue): Likewise. (WritePackArg): Likewise. * user.c (WriteExtractArgValue): Likewise. * utils.c (WriteFieldDeclPrim): Generate a union with an additional pointer field for variable-length arrays.
* Add static branch prediction to type checksJustus Winter2014-12-011-2/+7
| | | | | | | | | Annotate generated type checks with static branch prediction optimizing well-formed messages. * utils.c (WriteBogusDefines): Define `mig_unlikely' if not defined. * server.c: Use `mig_unlikely' in generated type checks. * user.c: Likewise.
* Drop the auto keywordJustus Winter2013-09-041-3/+3
| | | | | | | | | | Drop the auto keyword from the generated source code. auto is the default storage type for variables anyway and it is customary to omit it. * utils.c (WriteCheckDecl): Drop auto from generated source. (WriteStaticLongDecl): Likewise. (WriteStaticShortDecl): Likewise.
* Drop the register keywordJustus Winter2013-08-191-13/+13
| | | | | | | | | | | | | | | | | | | Drop the register keyword both from MIGs code and from the generated code. The register keyword is only a hint and it is ignored by modern compilers. * alloca.c: Drop the register keyword. * header.c: Likewise. * lexxer.l: Likewise. * parser.y: Likewise. * routine.c: Likewise. * server.c: Likewise. * statement.c: Likewise. * string.c: Likewise. * type.c: Likewise. * user.c: Likewise. * utils.c: Likewise. * vprint.c: Likewise.
* 2007-06-02 Thomas Schwinge <tschwinge@gnu.org>Thomas Schwinge2007-06-021-2/+0
| | | | | | | | | * global.c (LintLib): Remove definition. * global.h (LintLib): Remove declaration. * header.c (WriteUserRoutine, WriteServerRoutine): Don't emit `Lint' code. * user.c (WriteIncludes): Likewise. * utils.c (WriteRCSDecl): Likewise.
* 2004-03-18 Roland McGrath <roland@frob.com>Roland McGrath2004-03-181-17/+15
| | | | | | * utils.c (do_skip_vfprintf): New macro. (WriteCopyType, WritePackMsgType): Use that, so we do va_start and va_end independently around each SkipVFPrintf call.
* 2004-02-10 Roland McGrath <roland@frob.com>Roland McGrath2004-02-111-10/+16
| | | | | | | | * user.c (WriteTypeCheck): Use BAD_TYPECHECK macro instead of type-pun. * server.c (WriteTypeCheck): Likewise. * utils.c (WriteBogusDefines): Write a #define for that macro. * utils.c (WriteCheckDecl): Write auto const, not static const. (WriteStaticShortDecl, WriteStaticLongDecl): Likewise.
* Created new module from gnumach/mig at tag before-mig-moveRoland McGrath1998-07-181-0/+417
generated by cgit v1.2.3 (git 2.39.1) at 2025-04-04 11:28:44 +0000