diff options
| author | Dmitry V. Levin <ldv@altlinux.org> | 2020-06-15 16:00:00 +0000 |
|---|---|---|
| committer | Dmitry V. Levin <ldv@altlinux.org> | 2020-06-15 16:00:00 +0000 |
| commit | c5700c0a04c85ace09f6a179cc7a3692c07282b0 (patch) | |
| tree | 71fcb03768da05ba0412203a273b38de4a853582 | |
| parent | aef363c7e8e942224e6cffc4398366c6e5d31749 (diff) | |
| download | pam-c5700c0a04c85ace09f6a179cc7a3692c07282b0.tar.gz pam-c5700c0a04c85ace09f6a179cc7a3692c07282b0.tar.bz2 pam-c5700c0a04c85ace09f6a179cc7a3692c07282b0.zip | |
configure.ac: fix non-portable use of test builtin
Portable code should not assume that test builtin supports == operator.
* configure.ac (opt_uidmin, opt_sysuidmin, opt_kerneloverflowuid): Fix
initialization.
Resolves: https://github.com/linux-pam/linux-pam/issues/241
Fixes: 926d7935e ("pam_usertype: new module to tell if uid is in login.defs ranges")
| -rw-r--r-- | configure.ac | 15 |
1 files changed, 6 insertions, 9 deletions
diff --git a/configure.ac b/configure.ac index c1862ea7..7737efc7 100644 --- a/configure.ac +++ b/configure.ac @@ -662,21 +662,18 @@ dnl dnl Get values for default uid ranges in login.defs used in pam_usertype dnl AC_ARG_WITH([uidmin], AS_HELP_STRING([--with-uidmin=<number>],[default value for regular user min uid (1000)]), opt_uidmin=$withval) -if test x"$opt_uidmin" == x; then - opt_uidmin=1000 -fi +test -n "$opt_uidmin" || + opt_uidmin=1000 AC_DEFINE_UNQUOTED(PAM_USERTYPE_UIDMIN, $opt_uidmin, [Minimum regular user uid.]) AC_ARG_WITH([sysuidmin], AS_HELP_STRING([--with-sysuidmin=<number>],[default value for system user min uid (101)]), opt_sysuidmin=$withval) -if test x"$opt_sysuidmin" == x; then - opt_sysuidmin=101 -fi +test -n "$opt_sysuidmin" || + opt_sysuidmin=101 AC_DEFINE_UNQUOTED(PAM_USERTYPE_SYSUIDMIN, $opt_sysuidmin, [Minimum system user uid.]) AC_ARG_WITH([kerneloverflowuid], AS_HELP_STRING([--with-kernel-overflow-uid=<number>],[kernel overflow uid, default (uint16_t)-2=65534]), opt_kerneloverflowuid=$withval) -if test x"$opt_kerneloverflowuid" == x; then - opt_kerneloverflowuid=65534 -fi +test -n "$opt_kerneloverflowuid" || + opt_kerneloverflowuid=65534 AC_DEFINE_UNQUOTED(PAM_USERTYPE_OVERFLOW_UID, $opt_kerneloverflowuid, [Kernel overflow uid.]) AC_ARG_ENABLE([tally], |