diff options
| author | Tomas Mraz <tm@t8m.info> | 2005-11-02 12:41:34 +0000 |
|---|---|---|
| committer | Tomas Mraz <tm@t8m.info> | 2005-11-02 12:41:34 +0000 |
| commit | ff4104776bb51ff936fd1b62ec76d6e03db88d23 (patch) | |
| tree | d033a1e2814fae771473346722fd78d8078edb00 | |
| parent | 1f36364bf4be1aec03df54b67444b5c3eab18a0d (diff) | |
| download | pam-ff4104776bb51ff936fd1b62ec76d6e03db88d23.tar.gz pam-ff4104776bb51ff936fd1b62ec76d6e03db88d23.tar.bz2 pam-ff4104776bb51ff936fd1b62ec76d6e03db88d23.zip | |
Relevant BUGIDs: 1245888
Purpose of commit: bugfix
Commit summary:
---------------
* modules/pam_unix/pam_unix_passwd.c (_unix_verify_shadow): Change the
logic when comparing dates to handle corner cases better [#1245888].
| -rw-r--r-- | ChangeLog | 6 | ||||
| -rw-r--r-- | modules/pam_unix/pam_unix_passwd.c | 17 |
2 files changed, 19 insertions, 4 deletions
@@ -1,6 +1,10 @@ 2005-11-02 Tomas Mraz <t8m@centrum.cz> - * modules/pam_unix/support.c (_unix_getpwnam): Fix typo [#1224807]. + * modules/pam_unix/support.c (_unix_getpwnam): Fix typo [#1224807] + by ohyajapn. + + * modules/pam_unix/pam_unix_passwd.c (_unix_verify_shadow): Change the + logic when comparing dates to handle corner cases better [#1245888]. 2005-10-31 Thorsten Kukuk <kukuk@suse.de> diff --git a/modules/pam_unix/pam_unix_passwd.c b/modules/pam_unix/pam_unix_passwd.c index 727f3b3b..f433ab2c 100644 --- a/modules/pam_unix/pam_unix_passwd.c +++ b/modules/pam_unix/pam_unix_passwd.c @@ -923,10 +923,21 @@ static int _unix_verify_shadow(pam_handle_t *pamh, const char *user, unsigned in if (off(UNIX__IAMROOT, ctrl)) { /* Get the current number of days since 1970 */ curdays = time(NULL) / (60 * 60 * 24); - if ((curdays < (spwdent->sp_lstchg + spwdent->sp_min)) - && (spwdent->sp_min != -1)) + if (curdays < spent->sp_lstchg) { + pam_syslog(pamh, LOG_DEBUG, + "account %s has password changed in future", + uname); + curdays = spent->sp_lstchg; + } + if ((curdays - spwdent->sp_lstchg < spwdent->sp_min) + && (spwdent->sp_min != -1)) + /* + * The last password change was too recent. + */ retval = PAM_AUTHTOK_ERR; - else if ((curdays > (spwdent->sp_lstchg + spwdent->sp_max + spwdent->sp_inact)) + else if ((curdays - spent->sp_lstchg > spent->sp_max) + && (curdays - spent->sp_lstchg > spent->sp_inact) + && (curdays - spent->sp_lstchg > spent->sp_max + spent->sp_inact) && (spwdent->sp_max != -1) && (spwdent->sp_inact != -1) && (spwdent->sp_lstchg != 0)) /* |