diff options
| author | Thorsten Kukuk <kukuk@thkukuk.de> | 2006-05-22 17:27:54 +0000 |
|---|---|---|
| committer | Thorsten Kukuk <kukuk@thkukuk.de> | 2006-05-22 17:27:54 +0000 |
| commit | 9251be9693b1c8c56ed067438858e740cba57570 (patch) | |
| tree | 17fe57914bae9c80901e3288831a14f43524b539 /libpam | |
| parent | 747fce30ecb18b776fd91aefdcf3ab3508b42fbf (diff) | |
| download | pam-9251be9693b1c8c56ed067438858e740cba57570.tar.gz pam-9251be9693b1c8c56ed067438858e740cba57570.tar.bz2 pam-9251be9693b1c8c56ed067438858e740cba57570.zip | |
Relevant BUGIDs: 1490956,1489818,1489808,1489792,1489804,1489658,1489634
Purpose of commit: bugfixes
Commit summary:
---------------
2006-05-22 Thorsten Kukuk <kukuk@thkukuk.de>
* modules/pam_listfile/pam_listfile.c (pam_sm_authenticate):
Fix memory leaks, [#1490956] found by Coverity.
* modules/pam_tally/pam_tally.c (pam_get_uid): Check return
value of pam_get_user().
(tally_get_data): Check if oldtime is not NULL.
[#1489818] found by Coverity.
* modules/pam_mkhomedir/pam_mkhomedir.c (create_homedir): Don't
ignore return value of stat(). [#1489808] found by Coverity.
* modules/pam_mail/pam_mail.c (get_folder): Fix a potential
NULL pointer dereference. [#1489792] found by Coverity.
* libpam/Makefile.am: bump release number of libpam.so.
* libpam/pam_misc.c (_pam_mkargv): Fix memory leak,
[#1489804] found by Coverity.
* modules/pam_echo/pam_echo.c (replace_and_print): Initialize
str, [#1489658] found by Coverity.
* modules/pam_cracklib/pam_cracklib.c (_pam_unix_approve_pass): Fix
a potential NULL pointer dereference.
(pam_sm_chauthtok): Remove dead code.
[#1489634] found by Coverity.
Diffstat (limited to 'libpam')
| -rw-r--r-- | libpam/Makefile.am | 2 | ||||
| -rw-r--r-- | libpam/pam_misc.c | 6 |
2 files changed, 4 insertions, 4 deletions
diff --git a/libpam/Makefile.am b/libpam/Makefile.am index 951c1964..4648908b 100644 --- a/libpam/Makefile.am +++ b/libpam/Makefile.am @@ -20,7 +20,7 @@ include_HEADERS = $(addprefix include/security/, _pam_compat.h _pam_macros.h _pa noinst_HEADERS = pam_prelude.h pam_private.h pam_tokens.h \ pam_modutil_private.h pam_static_modules.h -libpam_la_LDFLAGS = -no-undefined -version-info 81:3:81 @LIBAUDIT@ +libpam_la_LDFLAGS = -no-undefined -version-info 81:4:81 @LIBAUDIT@ if STATIC_MODULES libpam_la_LDFLAGS += `ls ../modules/pam_*/*.lo` \ @LIBDB@ @LIBCRYPT@ @LIBNSL@ @LIBCRACK@ -lutil diff --git a/libpam/pam_misc.c b/libpam/pam_misc.c index 746c7a97..26590d09 100644 --- a/libpam/pam_misc.c +++ b/libpam/pam_misc.c @@ -170,11 +170,11 @@ int _pam_mkargv(char *s, char ***argv, int *argc) sbuf = NULL; D(("loop again?")); } - _pam_drop(sbuf_start); } + _pam_drop(sbuf_start); } } - + *argv = our_argv; D(("_pam_mkargv returned")); @@ -256,7 +256,7 @@ void _pam_parse_control(int *control_array, char *tok) error = "expecting '='"; goto parse_error; } - + /* skip leading space */ while (isspace((int)*tok) && *++tok); if (!*tok) { |