diff options
| author | Thorsten Kukuk <kukuk@thkukuk.de> | 2005-09-20 08:31:27 +0000 |
|---|---|---|
| committer | Thorsten Kukuk <kukuk@thkukuk.de> | 2005-09-20 08:31:27 +0000 |
| commit | cff33b6413b03978d6289542f9aec790f0785783 (patch) | |
| tree | 34abf1d042d90229f84c4bd1590f9488cf6d4806 /libpam_misc | |
| parent | ccfa4297f4081a42919afd793a615d09b965442c (diff) | |
| download | pam-cff33b6413b03978d6289542f9aec790f0785783.tar.gz pam-cff33b6413b03978d6289542f9aec790f0785783.tar.bz2 pam-cff33b6413b03978d6289542f9aec790f0785783.zip | |
Relevant BUGIDs: none
Purpose of commit: bugfix
Commit summary:
---------------
Fix missing NULL pointer check and us asprintf instead of malloc/snprintf
(from Dmitry V. Levin).
Diffstat (limited to 'libpam_misc')
| -rw-r--r-- | libpam_misc/help_env.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/libpam_misc/help_env.c b/libpam_misc/help_env.c index 2b800283..601c5f41 100644 --- a/libpam_misc/help_env.c +++ b/libpam_misc/help_env.c @@ -5,6 +5,8 @@ * */ +#include "config.h" + #include <stdlib.h> #include <stdio.h> #include <string.h> @@ -72,9 +74,7 @@ int pam_misc_setenv(pam_handle_t *pamh, const char *name return PAM_PERM_DENIED; /* not allowed to overwrite */ } } - tmp = malloc(2+strlen(name)+strlen(value)); - if (tmp != NULL) { - sprintf(tmp,"%s=%s",name,value); + if (asprintf(&tmp, "%s=%s", name, value) >= 0) { D(("pam_putt()ing: %s", tmp)); retval = pam_putenv(pamh, tmp); _pam_overwrite(tmp); /* purge */ |