tests: Add some pam_get_data tests

The function was not tested, so add some basic testing to it.

2 files changed, 181 insertions, 1 deletions

diff --git a/tests/Makefile.am b/tests/Makefile.am
index be7da35f..d7462dea 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -12,7 +12,7 @@ CLEANFILES = *~
 TESTS = tst-pam_start tst-pam_end tst-pam_fail_delay tst-pam_open_session \
 	tst-pam_close_session tst-pam_acct_mgmt tst-pam_authenticate \
 	tst-pam_chauthtok tst-pam_setcred tst-pam_get_item tst-pam_set_item \
-	tst-pam_getenvlist tst-pam_get_user tst-pam_set_data \
+	tst-pam_getenvlist tst-pam_get_user tst-pam_get_data tst-pam_set_data \
 	tst-pam_mkargv tst-pam_start_confdir
 
 EXTRA_DIST = confdir
diff --git a/tests/tst-pam_get_data.c b/tests/tst-pam_get_data.c
new file mode 100644
index 00000000..5f57b47a
--- /dev/null
+++ b/tests/tst-pam_get_data.c
@@ -0,0 +1,180 @@
+/*
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *    notice, and the entire permission notice in its entirety,
+ *    including the disclaimer of warranties.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *    notice, this list of conditions and the following disclaimer in the
+ *    documentation and/or other materials provided with the distribution.
+ * 3. The name of the author may not be used to endorse or promote
+ *    products derived from this software without specific prior
+ *    written permission.
+ *
+ * ALTERNATIVELY, this product may be distributed under the terms of
+ * the GNU Public License, in which case the provisions of the GPL are
+ * required INSTEAD OF the above restrictions.  (This clause is
+ * necessary due to a potential bad interaction between the GPL and
+ * the restrictions contained in a BSD-style copyright.)
+ *
+ * THIS SOFTWARE IS PROVIDED ``AS IS'' AND ANY EXPRESS OR IMPLIED
+ * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
+ * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+ * DISCLAIMED.  IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT,
+ * INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
+ * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
+ * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
+ * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
+ * STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED
+ * OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#ifdef HAVE_CONFIG_H
+#include <config.h>
+#endif
+
+#include <stdio.h>
+#include <unistd.h>
+#include <string.h>
+
+#include <security/pam_appl.h>
+#include <security/pam_modules.h>
+#include <pam_private.h>
+
+static void
+tst_str_data_cleanup (pam_handle_t *pamh UNUSED, void *data, int error_status)
+{
+  fprintf (stderr, "tst_cleanup was called: data=\"%s\", error_status=%d\n",
+	   (char *)data, error_status);
+  free (data);
+}
+
+int
+main (void)
+{
+  const char *service = "dummy";
+  const char *user = "root";
+  struct pam_conv conv = { NULL, NULL };
+  pam_handle_t *pamh;
+  void *dataptr;
+  const void *constdataptr;
+  int retval;
+
+  /* 1: Call with NULL as pam handle */
+  retval = pam_get_data (NULL, "tst-pam_get_data-1", &constdataptr);
+  if (retval == PAM_SUCCESS)
+    {
+      fprintf (stderr, "test1: pam_get_data (NULL, ...) returned PAM_SUCCESS\n");
+      return 1;
+    }
+
+  /* setup pam handle */
+  retval = pam_start (service, user, &conv, &pamh);
+  if (retval != PAM_SUCCESS)
+    {
+      fprintf (stderr, "pam_start (%s, %s, &conv, &pamh) returned %d (%s)\n",
+               service, user, retval, pam_strerror (pamh, retval));
+      return 1;
+    }
+
+  /* 2: check for call from application */
+  retval = pam_get_data (pamh, "tst-pam_get_data-2", &constdataptr);
+  if (retval != PAM_SYSTEM_ERR)
+    {
+      fprintf (stderr,
+	       "test2: pam_get_data returned %d when expecting PAM_SYSTEM_ERR\n",
+	       retval);
+      return 1;
+    }
+
+  /* 3: Check that pam data is properly set and replaced */
+  __PAM_TO_MODULE(pamh);
+  dataptr = strdup ("test3a");
+  retval = pam_set_data (pamh, "tst-pam_get_data-3", dataptr,
+			 tst_str_data_cleanup);
+  if (retval != PAM_SUCCESS)
+    {
+      free (dataptr);
+      fprintf (stderr,
+	       "test3a: first pam_set_data failed: %d (%s)\n",
+	       retval, pam_strerror (pamh, retval));
+      return 1;
+    }
+
+  retval = pam_get_data (pamh, "tst-pam_get_data-3", &constdataptr);
+  if (retval != PAM_SUCCESS)
+    {
+      fprintf (stderr,
+	       "test3a: first pam_get_data failed: %d (%s)\n",
+	       retval, pam_strerror (pamh, retval));
+      return 1;
+    }
+
+  if (constdataptr != dataptr)
+    {
+      fprintf (stderr,
+	       "test3a: first pam_get_data data is not matching %p: %p\n",
+	       constdataptr, dataptr);
+      return 1;
+    }
+
+  if (strcmp ((const char *) constdataptr, "test3a") != 0)
+    {
+      fprintf (stderr,
+	       "test3a: first pam_get_data strings are not matching: '%s' vs '%s'\n",
+	       (const char *) constdataptr, "test3a");
+      return 1;
+    }
+
+  dataptr = strdup ("test3a");
+  retval = pam_set_data (pamh, "tst-pam_get_data-3", dataptr,
+			 tst_str_data_cleanup);
+  if (retval != PAM_SUCCESS)
+    {
+      free (dataptr);
+      fprintf (stderr,
+	       "test3a: second pam_set_data failed: %d (%s)\n",
+	       retval, pam_strerror (pamh, retval));
+      return 1;
+    }
+
+  retval = pam_get_data (pamh, "tst-pam_get_data-3", &constdataptr);
+  if (retval != PAM_SUCCESS)
+    {
+      fprintf (stderr,
+	       "test3a: second pam_get_data failed: %d (%s)\n",
+	       retval, pam_strerror (pamh, retval));
+      return 1;
+    }
+
+  if (constdataptr != dataptr)
+    {
+      fprintf (stderr,
+	       "test3a: second pam_get_data data is not matching %p: %p\n",
+	       constdataptr, dataptr);
+      return 1;
+    }
+
+  if (strcmp ((const char *) constdataptr, "test3a") != 0)
+    {
+      fprintf (stderr,
+	       "test3a: second pam_get_data strings are not matching: '%s' vs '%s'\n",
+	       (const char *) constdataptr, "test3a");
+      return 1;
+    }
+
+  __PAM_TO_APP(pamh);
+
+  retval = pam_end (pamh, 987);
+  if (retval != PAM_SUCCESS)
+    {
+      fprintf (stderr,
+	       "pam_end reported an error: %d (%s)\n",
+	       retval, pam_strerror (pamh, retval));
+      return 1;
+    }
+
+  return 0;
+}