aboutsummaryrefslogtreecommitdiff
path: root/libdiskfs
Commit message (Collapse)AuthorAgeFilesLines
* libdiskfs: Check for EROFS on io_prenotify and io_write tooSamuel Thibault2025-02-042-1/+7
| | | | | | | | This avoids Assertion `!diskfs_readonly' failed. messages at shutdown.
* libdiskfs: Avoid crashing on system shutdownSamuel Thibault2025-01-171-3/+5
| | | | | when processes which were upgraded didn't get restarted, and stop after making the filesystem readonly.
* libdiskfs: catch mmap failureSamuel Thibault2025-01-114-11/+37
| | | | Just backtrace for now
* Add a description comment for the MIG type translation filesZhaoming Luo2024-12-141-1/+2
| | | | | Signed-off-by: Zhaoming Luo <zhmingluo@163.com> Message-ID: <20241213005831.748151-1-zhmingluo@163.com>
* Fix line-buffered stderrSamuel Thibault2024-08-251-0/+1
| | | | | mach_open_devstream creates a fully-buffered stream by default. This prevents from seeing various messages.
* libdiskfs: Print error if we fail to open /dev/consoleSamuel Thibault2024-08-251-6/+14
|
* Make sure to also print early-fatal errors on mach consoleSamuel Thibault2024-08-251-2/+6
| | | | In case the user is using a debug kernel, they will get to see these.
* netfs and diskfs: make showtrans work correctly when translators are set on ↵Flavio Cruz2024-07-101-20/+17
| | | | | | | | | top of sylink/device/fifo/socket files. While these are short-circuited translators and simply change st_mode, actual translators can be set on top. We want `showtrans` to show the actual passive translator, not the short-circuited one. Message-ID: <b3ujoovkmz3iagqkmv6lyzgqsv3g5u2wiaqwktlttbalyd7oak@6qeiiupzzmag>
* Cast bootinfo to struct diskfs_control * to silence warningFlavio Cruz2023-12-291-1/+1
| | | | Message-ID: <20231229212105.858759-2-flaviocruz@gmail.com>
* Replace deprecated sigmask with sigset_t callsFlavio Cruz2023-12-291-1/+3
| | | | Message-ID: <20231229161211.312389-2-flaviocruz@gmail.com>
* Update server handlers to return kern_return_error to fix ↵Flavio Cruz2023-12-1713-13/+13
| | | | | | | -Werror=enum-int-mismatch warnings MiG expects those to return kern_return_t. Message-ID: <ZXqbbXpVqQAwd2qv@jupiter.tail36e24.ts.net>
* S_dir_lookup: Handle O_DIRECTORYSamuel Thibault2023-09-021-1/+2
| | | | | When e.g. looking up a socket with O_DIRECTORY, we should return ENOTDIR rather than EACCESS.
* Revert "S_dir_lookup: Handle O_DIRECTORY"Samuel Thibault2023-09-021-1/+1
| | | | | | This reverts commit 8b5b59c704e9edbb0784697ada1df9112fc3e18b. This actually breaks various posix behaviors.
* S_dir_lookup: Handle O_DIRECTORYSamuel Thibault2023-09-021-1/+1
| | | | | When e.g. looking up a socket with O_DIRECTORY, we should return ENOTDIR rather than EACCESS.
* file-syncfs: Avoid deadlockSamuel Thibault2023-08-121-17/+19
| | | | | | | | | | | | | | | | | | | | | This is a four-player problem (here for diskfs): - One runs sync, which calls diskfs_S_file_syncfs, which triggers fsys_syncfs on all active translators, while keeping the translator_ihash_lock lock. - One of the active translators is hung, for some reason - Another ext2fs thread is trying to call fshelp_set_active_translator from dir_lookup. It is stuck on trying to acquire translator_ihash_lock, and it holds the np. - The ext2fs thread running diskfs_sync_everything tries to lock that np, while holding the nodecache_lock. In the end everything is locked. While diskfs_S_file_syncfs can as well just atomically get the list of active translators, and then call fsys_syncfs without keeping translator_ihash_lock held.
* Homogeneize [gs]et_translator and get_dire[nc]ts into mach_msg_type_number_tSamuel Thibault2023-08-084-17/+9
| | | | | | | | | | | | | | | | | This makes netfs_[gs]et_translator use mach_msg_type_number_t like the RPC and diskfs. This also makes the fshelp_fetch_root_callback1_t for fshelp_fetch_root use mach_msg_type_number_t. This also makes procfs_get_translator and the get_translator proc method use mach_msg_type_number_t. This makes diskfs_get_directs use mach_msg_type_number_t like the dir_readdir RPC Also get rid of u_int. This notably fixes _diskfs_translator_callback1_fn's bogus cast of size_t *argz_len into (u_int *).
* libdiskfs: Don't warn if requesting shutdown notification fails with EPERMSergey Bugaev2023-07-031-2/+4
| | | | | | | | | | The code already ignores proc_mark_important failing with EPERM; do the same for opening /servers/startup and startup_request_notification. All of these calls will fail for unprivileged mounts. Also plug a port leak: we want to deallocate the "init" port whether the RPC succeeds or not. Message-Id: <20230625231137.403096-1-bugaevc@gmail.com>
* libdiskfs: Port to x86_64Sergey Bugaev2023-05-1016-82/+99
| | | | Message-Id: <20230508213136.608575-9-bugaevc@gmail.com>
* Use uintptr_t for message payloads.Flavio Cruz2023-05-021-6/+6
| | | | | A follow up to 92fad38a043b75ed6b435b3efa574ede91dbe9ee in gnumach. Message-Id: <ZFCNasf9bJ9qj+CG@jupiter.tail36e24.ts.net>
* Further modernize Hurd code by enforcing strict prototypes and no implicit ↵Flavio Cruz2023-04-082-8/+8
| | | | | | | | | | | | | | | | | | function declarations. Most of the changes land in one of these buckets: * Removed unused declarations. * Used (void) to represent no parameters instead of () which means an undeterminate number of parameters. * Included missing header files whenever necessary (stdlib.h, sys/mman.h, etc) * Typedefed function pointers to be able to fully declare the parameter types. * Added declarations of library functions that are used elsewhere (example is libps/ps.h). * Made functions static whenever they are only used in that file. * Forwarded declarations of some methods that were made static. Message-Id: <ZDD1o7/tVYeZew+G@jupiter.tail36e24.ts.net>
* Use default pager MiG stubs from Hurd instead of gnumachFlavio Cruz2023-04-071-1/+1
| | | | | | | | | | | | Hurd code relies on gnumach default_pager.defs headers when making calls using the default pager RPC. Those stubs were checked in back in the 90s and are essentially unused because gnumach does not implement or use that interface. Instead use the Hurd interface directly. This is safe since the Hurd stubs are a super set of the gnumach stubs. Later, we won't need to install the gnumach stubs anymore through glibc. Message-Id: <ZC5WqPKfCCiE8D29@jupiter.tail36e24.ts.net>
* Modernize code by removing use of old style definitions.Flavio Cruz2023-04-035-6/+6
| | | | | Also add -Werror=old-style-definition to enforce new code. Message-Id: <ZBZ+8xf7GHy2RT/h@jupiter.tail36e24.ts.net>
* fsys_get_children: Fix double-free on errorSamuel Thibault2023-01-021-1/+1
|
* fsys_get_children: Fix comparing stringsSamuel Thibault2023-01-021-1/+1
|
* fsys_get_children: Fix memleak on errorSamuel Thibault2023-01-021-2/+6
|
* Fix accessing cred before checking it is non-NULLSamuel Thibault2023-01-011-1/+2
|
* libdiskfs: white-list fall-through in switchSamuel Thibault2023-01-011-0/+1
|
* make_peropen: Fix memory leaks on errorSamuel Thibault2023-01-011-2/+9
|
* fsys_get_children: Fix double-free on errorSamuel Thibault2023-01-011-1/+1
|
* Fix *printf specifier for user space mach ports.Flavio Cruz2022-12-061-1/+1
| | | | | mach_port_t are mach_port_name_t and thus require %u instead of %lu. Message-Id: <Y42RELMbulK4xaKM@reue>
* libdiskfs: Add missing includeSamuel Thibault2022-08-301-0/+1
|
* libdiskfs: Avoid crashing when stdout/err shuts downSamuel Thibault2022-08-301-0/+4
| | | | | | stdout/err could shut down for whatever reason (killed the term on /dev/console or whatever). We should not crash just because we lost our ability to print output.
* Fix types of read write and readables methodsEtienne Brateau2022-08-293-3/+3
| | | | Message-Id: <20220829193617.13481-1-etienne.brateau@gmail.com>
* file_exec: Homogeneize adding the gratuitous send rightSamuel Thibault2022-08-231-0/+4
|
* libnetfs, libtrivs: Shield S_file_exec_paths () from cancellationSergey Bugaev2022-08-101-1/+3
| | | | | | | | | | | | | | | | | | | | | | | Here's the sequence of events that leads to a bug: * A task calls file_exec_paths () on itself, holding the only send right to the protid, passing EXEC_NEWTASK (or EXEC_SECURE, which implies it). * S_file_exec_paths () calls exec_exec_paths () * The exec server sets up a new task and calls proc_reassign () or proc_reauthenticate_reassign (). * The proc server destroys the old task, and the only send right to the protid with it. * The translator gets a no-senders notification, which results in a ports_interrupt_rpcs () call on the S_file_exec_paths (). * This propagates to the exec server (and potentially proc and auth servers). * The exec gets canceled, and the new task gets killed. In my opinion, the party that seems most guilty is the translator canceling exec upon receiving a no-senders notification for the protid. Normally, a no-senders notification means that the caller is no longer interested in the RPC, but this is not true in case of exec. To work around this, create an additional send right to the protid.
* libdiskfs, libnetfs: Disable broken codeSergey Bugaev2022-08-101-1/+6
| | | | This logic is obviously broken, let's disable it for now.
* diskfs: Use libports notificationsSergey Bugaev2022-08-103-10/+7
| | | | | Namely, ports_request_dead_name_notification () where we can, and the libports notify port when we have to pass it to libfshelp.
* Do not cache the R/O proxySamuel Thibault2022-08-101-0/+1
| | | | | We cannot properly detect when to release the ro_proxy, so let's just not cache it.
* typoSamuel Thibault2022-01-231-1/+1
|
* libdiskfs: improve asserts and remove a sign compare warningEtienne Brateau2022-01-201-1/+2
| | | | Message-Id: <20220119192945.36654-4-etienne.brateau@gmail.com>
* Fix const warningsSamuel Thibault2022-01-173-3/+3
| | | | | Now that the RPCs have const, this forces us cleaning our const-meant functions.
* Make RPC input array parameters constSamuel Thibault2022-01-1615-38/+38
| | | | | This follows mig's cf4bcc3f1435 ("Also add const qualifiers on server side")
* Fix build warningsSamuel Thibault2022-01-019-12/+12
| | | | No actual behavior change.
* libdiskfs: Flush node to disk before removing it from the cacheSamuel Thibault2021-08-111-0/+4
| | | | | | libdiskfs' dosync goes through the cache to flush nodes to the disk. We thus have to flush a node to the disk before removing it from the cache in diskfs_try_dropping_softrefs.
* bootstrap: Fix passing proc server from FS to rumpdiskSamuel Thibault2021-08-111-22/+18
| | | | | libdiskfs was passing its own proc port, thus confusing the fsys_init call in rumpdisk.
* Call _hurd_libc_proc_init when availableSamuel Thibault2021-04-111-0/+3
| | | | | | | | | | | glibc 2.33 separated out _hurd_libc_proc_init from _hurd_init, so we have to additionally call it. * configure.ac (_hurd_libc_proc_init): Detect function. * libdiskfs/boot-start.c (diskfs_S_fsys_init): Call _hurd_libc_proc_init. * libmachdev/trivfs_server.c (trivfs_S_fsys_init): Call _hurd_libc_proc_init.
* libdiskfs: do not reuse pathbufSamuel Thibault2020-11-271-6/+2
| | | | | | | | | When deadling with multiple levels of symlinks, we really need double buffering between the current path and the symlink target, and thus cannot reuse pathbuf. * libdiskfs/dir-lookup.c (diskfs_S_dir_lookup): Always use alloca for pathbuf.
* libdiskfs: enable relatime by defaultSamuel Thibault2020-10-102-2/+2
| | | | | | | | | Like Linux does, to avoid writing inodes when just reading files already in the cache. * libdiskfs/init-init.c (_diskfs_relatime): Set to 1. * libdiskfs/opts-std-runtime.c (set_opts): Always _diskfs_relatime from h->relatime.
* libdiskfs: Make relatime also update atime when equal to mtime/ctimeSamuel Thibault2020-10-031-2/+2
| | | | | | | Some tests (such as glibc's tst-atime) require it for instance. * libdiskfs/node-times.c (atime_should_update): Also return 1 when atime is equal to mtime or ctime.
* libdiskfs: Add relatime supportRyan Jeffrey2020-09-3011-11/+90
| | | | | | | | | | | | | | | | | | | | | | | | * doc/hurd.texi (diskfs_set_node_atime): Document relatime behavior. * libdiskfs/diskfs.h (diskfs_set_node_atime): Likewise. * libdiskfs/init-init.c (_diskfs_relatime): Add variable. * libdiskfs/file-statfs.c (ST_RELATIME): Define if not defined already. (diskfs_S_file_statfs): Report ST_RELATIME when _diskfs_relatime is set. * libdiskfs/node-times.c (atime_should_update): New function. (diskfs_set_node_atime): Document relatime behavior. Call atime_should_update instead of reading _diskfs_noatime. * libdiskfs/opts-common.c (diskfs_common_options): Add --strictatime and -R/--relatime options. * libdiskfs/opts-std-runtime.c (struct parse_hook): Add relatime field. (set_opts): Set _diskfs_relatime from relatime field. (parse_opt): Parse -R option. * libdiskfs/opts-std-startup.c (parse_startup_opt): Parse -R option. * libdiskfs/priv.h (_diskfs_relatime): Declare variable. (atime_should_update): Declare function. * libdiskfs/opts-append-std.c (diskfs_append_std_options): Add reporting --relatime option. * libdiskfs/conch-fetch.c (iohelp_fetch_shared_data): Call atime_should_update instead of reading _diskfs_noatime. * libdiskfs/rdwr-internal.c (_diskfs_rdwr_internal): Likewise.
generated by cgit v1.2.3 (git 2.39.1) at 2025-04-04 11:28:32 +0000